valithor/dev
1
0
Fork 0
forked from PHP/Router
Code Pull Requests Activity

Optimize $params using array_reduce

Browse Source
This commit is contained in:
Valithor Obsidion 2024-12-25 10:44:20 -05:00
parent 49819b41bd
commit 4df658fc1c
1 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/SegmentRouter.php
View File

@ -78,31 +78,33 @@ class SegmentRouter implements RouterInterface
} }
// params will hold any dynamic segments we find // params will hold any dynamic segments we find
$params = []; $params = array_reduce(
explode('/', trim($uri, '/')),
// We'll split up the URI into segments and traverse the node tree function ($carry, $segment) use (&$node) {
foreach (explode('/', trim($uri, '/')) as $segment) {
// if there is a node for this segment, move to it
if (isset($node[$segment])) { if (isset($node[$segment])) {
$node = $node[$segment]; $node = $node[$segment];
continue; } elseif (isset($node[':x'])) {
} $carry[] = $segment;
// if there is a dynamic segment, move to it and store the value
if (isset($node[':x'])) {
$params[] = $segment;
$node = $node[':x']; $node = $node[':x'];
continue; } else {
} throw new \Exception('404');
// if we can't find a node for this segment, return 404
return ['code' => 404, 'handler' => null, 'params' => []];
} }
return $carry;
},
[]
);
// if we found a handler for the method, return it and any params. if not, return a 405 // if we found a handler for the method, return it and any params. if not, return a 405
return isset($node[$method]) return isset($node[$method])
? ['code' => 200, 'handler' => $node[$method], 'params' => $params ?? []] ? [
: ['code' => 405, 'handler' => null, 'params' => []]; 'code' => 200,
'handler' => $node[$method],
'params' => $params ?? []]
: [
'code' => 405,
'handler' => null,
'params' => []
];
} }
/** /**