minor modernizations

internal/classes/classes_test.go

@@ -1,11 +1,9 @@
 package classes
 
 import (
-	"math/rand"
 	"strings"
 	"sync"
 	"testing"
-	"time"
 )
 
 // Mock entity implementations for testing
@@ -733,7 +731,7 @@ func TestGetClassStatistics(t *testing.T) {
 	adventureClasses := stats["adventure_classes"].(int)
 	tradeskillClasses := stats["tradeskill_classes"].(int)
 
-	if totalClasses != adventureClasses + tradeskillClasses {
+	if totalClasses != adventureClasses+tradeskillClasses {
 		t.Errorf("Total classes (%d) should equal adventure (%d) + tradeskill (%d)",
 			totalClasses, adventureClasses, tradeskillClasses)
 	}
@@ -1545,7 +1543,7 @@ func TestClassesConcurrency(t *testing.T) {
 	var wg sync.WaitGroup
 
 	// Concurrent reads
-	for i := 0; i < 100; i++ {
+	for i := range 100 {
 		wg.Add(1)
 		go func(classID int8) {
 			defer wg.Done()
@@ -1571,7 +1569,7 @@ func TestClassManagerConcurrency(t *testing.T) {
 	var wg sync.WaitGroup
 
 	// Concurrent usage registration
-	for i := 0; i < 100; i++ {
+	for i := range 100 {
 		wg.Add(1)
 		go func(classID int8) {
 			defer wg.Done()
@@ -1580,7 +1578,7 @@ func TestClassManagerConcurrency(t *testing.T) {
 	}
 
 	// Concurrent stats reading
-	for i := 0; i < 50; i++ {
+	for range 50 {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()
@@ -1609,7 +1607,7 @@ func TestMockEntitiesConcurrency(t *testing.T) {
 	var wg sync.WaitGroup
 
 	// Concurrent reads and writes
-	for i := 0; i < 100; i++ {
+	for i := range 100 {
 		wg.Add(1)
 		go func(classID int8) {
 			defer wg.Done()
@@ -1631,64 +1629,56 @@ func TestMockEntitiesConcurrency(t *testing.T) {
 // Benchmarks
 func BenchmarkGetClassID(b *testing.B) {
 	classes := NewClasses()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		classes.GetClassID("WARRIOR")
 	}
 }
 
 func BenchmarkGetClassName(b *testing.B) {
 	classes := NewClasses()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		classes.GetClassName(ClassWarrior)
 	}
 }
 
 func BenchmarkGetBaseClass(b *testing.B) {
 	classes := NewClasses()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		classes.GetBaseClass(ClassGuardian)
 	}
 }
 
 func BenchmarkGetAllClasses(b *testing.B) {
 	classes := NewClasses()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		classes.GetAllClasses()
 	}
 }
 
 func BenchmarkParseClassName(b *testing.B) {
 	utils := NewClassUtils()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		utils.ParseClassName("WARRIOR")
 	}
 }
 
 func BenchmarkGetRandomClassByType(b *testing.B) {
 	utils := NewClassUtils()
-	rand.Seed(time.Now().UnixNano())
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		utils.GetRandomClassByType(ClassTypeAdventure)
 	}
 }
 
 func BenchmarkRegisterClassUsage(b *testing.B) {
 	manager := NewClassManager()
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		manager.RegisterClassUsage(ClassWarrior)
 	}
 }
@@ -1696,18 +1686,16 @@ func BenchmarkRegisterClassUsage(b *testing.B) {
 func BenchmarkValidateEntityClass(b *testing.B) {
 	integration := NewClassIntegration()
 	entity := NewMockClassAware(ClassWarrior)
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		integration.ValidateEntityClass(entity)
 	}
 }
 
 func BenchmarkMockClassAwareGetSet(b *testing.B) {
 	entity := NewMockClassAware(ClassWarrior)
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		entity.SetClass(ClassCleric)
 		entity.GetClass()
 	}